Refactor #125
Merged
Refactor #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…keyword arguments
In the original design, command to long will not be run. I use the code how invoke runs sunbprocess. https://github.com/pyinvoke/invoke/blob/master/invoke/runners.py#L1271
… into conftest they're commonly used fixture among all tests
…guish bump_setting and argument
|
Thanks Lee! |
|
Thank you for the prompt review 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commitizen.cmdinteract with shellgit tagwith long argumentsGitObject(GitTag,GitCommit) classes to store git informationI start working on changelog (#53) on my changelog branch and have a prototype of it.
However, the pull request will be too huge to review if I send it after I finish all the functionality.
Thus, I separate the changelog related commits and other refactor commits which are changed as a preparation for the new functionality.
This PR is for the refactor ones.